REF: be stricter about what we pass to _simple_new #31055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jan 15, 2020
jbrockmendel
changed the title
This was referenced Jan 16, 2020
jreback
reviewed
Jan 18, 2020
| @@ -420,7 +421,8 @@ def insert(self, loc, item): | |||
| new_i8s = np.concatenate( | |||
| (self[:loc].asi8, [item.view(np.int64)], self[loc:].asi8) | |||
| ) | |||
| return self._shallow_copy(new_i8s, freq=freq) | |||
| tda = type(self._data)._simple_new(new_i8s, freq=freq) | |||
There was a problem hiding this comment.
no, simple_new doesnt make a copy
There was a problem hiding this comment.
k, that's what i thought, can you (followup ok), document this loudly in the _simple_new
|
also I would document in simple_new what the copy guarantees are |
|
thanks, followon comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will take a few passes to get rid of all the checks done in _simple_new that should be done elsewhere