DOC: Fix HDF5 complevel and complib formatting #31053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the PR!
I am not fully sure this will actually change a lot in the final formatting (it's still formatted as a rst definition list, http://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#lists-and-quote-like-blocks).
I was thinking to just make it 2 bullet points? (the complevel and complib)
jorisvandenbossche
changed the title
|
can you post a screen shot of the rendered |
jorisvandenbossche
approved these changes
Jan 20, 2020
My experience rst eye says this is proper formatting for a list ;) So it should be good. |
|
Thanks @kylekeppler ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes formatting of these params.
black pandas(N/A)git diff upstream/master -u -- "*.py" | flake8 --diff(N/A)N/A as this PR only updates an rst file for the docs.