-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
FIX: fix interpolate with kwarg limit area and limit direction using pad or bfill #31048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
cchwala
wants to merge
33
commits into
pandas-dev:master
from
cchwala:fix_interpolate_limit_area_and_limit_direction_with_pad
Closed
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
9afe992
Added failing test for https://github.com/pandas-dev/pandas/issues/26796
cchwala 3a191b9
Added implementation to support `limit_area`
cchwala fd5d8e8
fix test
cchwala 26d88ed
pep8
cchwala 6597aca
fixed small error that actually had no effect since the input array `…
cchwala c536d3c
Raise when forbidden combination of `method` and `limit_direction` ar…
cchwala ed9cf21
Updated docstring with info about allowed combinations of `method` an…
cchwala 2980325
clean up
cchwala ecf428e
Added entry to whatsnew file
cchwala f8a3423
Removed `axis` kwarg from `interpolate_1d_fill` because it was unused
cchwala 6733186
Type annotations added to new function `interpolate_1d_fill`
cchwala c5b77d2
fixed incorrectly sorted imports
cchwala 0bb36de
Added type annotation, updated docstring and removed unnecessary argu…
cchwala a467afd
Reverting docstring entry for default value of `limit_direction`
cchwala 5466d8c
Moved logic for calling `missing.interpolate_1d_fill` to `missing.int…
cchwala 3e968fc
Moved whatsnew entry to v1.1.0.rst
cchwala 556a3cf
clean up
cchwala 6c1e429
fixed missing Optional in type definition
cchwala 767b0ca
small fix so that CI type validation does not complain
cchwala b82aaff
Merge remote-tracking branch 'upstream/master' into fix_interpolate_l…
cchwala 26ef7b5
Apply suggestions from code review concerning list instead of set
cchwala b4b6b5a
added import for missing List type
cchwala e259549
fixed unsorted order of imports
cchwala 8ceff58
Merge remote-tracking branch 'upstream/master' into fix_interpolate_l…
cchwala 7c5ad7d
Added tests back in
cchwala 92148ff
Added new solution to account for limit_area with pad
cchwala d62e02e
black formatting
cchwala c2473f2
added whatsnew entry
cchwala 610e347
Test with moving logic for interpolate_2d with `limite_area` directly…
cchwala 570e3c2
fix wrong arg order by using kwargs as suggested in https://github.co…
cchwala 721304a
Added comment to explain recursion and added typing for interpolate_2d
cchwala 73ab1bf
improved test code coverage
cchwala a33f629
fixed wrong typing
cchwala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make this a module level function and just call it here