Skip to content

TST: Split test_offsets.py - Test_offsets moved to test_date_offsets #31031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

TST: Split test_offsets.py - Test_offsets moved to test_date_offsets #31031

wants to merge 3 commits into from

Conversation

Raalsky
Copy link

@Raalsky Raalsky commented Jan 15, 2020

In context of https://github.com/pandas-dev/pandas/pull/30194
First part with move test_offsets to test_date_offsets

@Raalsky Raalsky marked this pull request as ready for review January 15, 2020 07:53
@Raalsky Raalsky changed the title Test_offsets moved to test_date_offsets TST: Split test_offsets.py - Test_offsets moved to test_date_offsets Jan 15, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what i mean is to split up the files in this PR
just don’t change things except to add/remove imports as needed

@WillAyd
Copy link
Member

WillAyd commented Jan 15, 2020

Are you planning to split this module up? Just reading back through the original PR I think that is the request; not just to rename it

@WillAyd
Copy link
Member

WillAyd commented Feb 12, 2020

Closing as I think this is stale but @Raalsky ping if you'd like to pick back up and can address comments

@WillAyd WillAyd closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Split test_offsets.py
3 participants