Skip to content

BUG: Preserve string dtype in extract #31018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

TomAugspurger
Copy link
Contributor

specifically with multiple capture groups and expand=False

Closes #30969

specifically with multiple capture groups and expand=False

Closes pandas-dev#30969
@TomAugspurger TomAugspurger added this to the 1.0.0 milestone Jan 14, 2020
@TomAugspurger TomAugspurger added ExtensionArray Extending pandas with custom dtypes or arrays. Strings String extension data type and string data labels Jan 14, 2020
@jbrockmendel
Copy link
Member

LGTM

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well

@jreback jreback merged commit 6837794 into pandas-dev:master Jan 15, 2020
@jreback
Copy link
Contributor

jreback commented Jan 15, 2020

thanks @TomAugspurger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

str.extract(expand=False) on a string typed series returns an object typed dataframe
4 participants