Skip to content

DOC: Moved PANDAS_TESTING_MODE tip to .travis.yml (#30694) #31008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2020

Conversation

saloni30agr
Copy link
Contributor

@saloni30agr saloni30agr commented Jan 14, 2020

Added comments for travis.yml for PANDAS_TESTING_MODE from tips and tricks section of wiki

Added comments for travis.yml for PANDAS_TESTING_MODE from tips and tricks section of wiki
.travis.yml Outdated
@@ -43,6 +43,9 @@ matrix:
- postgresql

- env:
# Enabling Deprecations when running tests
# You can set the environment variable PANDAS_TESTING_MODE to deprecate to show any DeprecationWarning message.
# This is enabled in the travis builds for numpy 1.9 (and evenutally for the python 3.4 build).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think can delete this last line; pretty out of date

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, also you can rephrase a bit, since this is a comment and not in the docs anymore. Something like PANDAS_TESTING_MODE="deprecate" causes DeprecationWarning messages to be displayed in the logs. See pandas/_testing.py for more details.

@saloni30agr saloni30agr requested a review from WillAyd January 18, 2020 06:12
@jreback jreback added this to the 1.1 milestone Jan 18, 2020
@jreback jreback merged commit a3c7722 into pandas-dev:master Jan 18, 2020
@jreback
Copy link
Contributor

jreback commented Jan 18, 2020

thanks @datapythonista i don't believe this closes the referenced issue.

@datapythonista
Copy link
Member

Agree, we need to see if there is anything else in that wiki we want to keep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants