-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: removed wrong value of pd.NA ** 0
#31005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead, the values are auto-calculated
Nice! Seems like a good decision to put this inside an |
I think I prefer this as a table so that it is formatted nicely in the docs. Curious to hear what others think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy either way. If I had to choose, I'd probably go for the ipython block, but I don't have much of a preference.
pd.NA ** 0
pd.NA ** 0
Let's go with that then. |
@TomAugspurger should the auto-backport kick-in moreless straight-away |
Oh, whoops, this was merged to the wrong branch. PRs should go to master. |
So, I think I will revert this, make a new PR to master, and then use the bot to backport it... Probably not necessary, but let's do it to not mess up history / branching. |
This reverts commit da04c9a.
(cherry picked from commit da04c9a)
This reverts commit da04c9a.
OK, reverted on 1.0.x, and made #31003 to master (which will be backported). |
Co-authored-by: tsvikas <[email protected]>
…) (#31019) Co-authored-by: Tom Augspurger <[email protected]>
I thought we need to work on the development branch, and bit on master. Hmmm. How axtually do you manage your Branch's in pandas? |
Everything is merged in master, and the appropriate commits for 1.0.0 are backported into the 1.0.x branch. So in practice, almost all PRs should target the master branch. |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff