Skip to content

DOC: removed wrong value of pd.NA ** 0 #31005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2020
Merged

DOC: removed wrong value of pd.NA ** 0 #31005

merged 1 commit into from
Jan 14, 2020

Conversation

tsvikas
Copy link
Contributor

@tsvikas tsvikas commented Jan 14, 2020

Instead, the values are auto-calculated
@simonjayhawkins simonjayhawkins added this to the 1.0.0 milestone Jan 14, 2020
@MarcoGorelli
Copy link
Member

MarcoGorelli commented Jan 14, 2020

Nice! Seems like a good decision to put this inside an ipython block to avoid similar mistakes in the future

@TomAugspurger
Copy link
Contributor

I think I prefer this as a table so that it is formatted nicely in the docs. Curious to hear what others think.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy either way. If I had to choose, I'd probably go for the ipython block, but I don't have much of a preference.

@datapythonista datapythonista changed the title docs: removed wrong value of pd.NA ** 0 DOC: removed wrong value of pd.NA ** 0 Jan 14, 2020
@TomAugspurger
Copy link
Contributor

Let's go with that then.

@TomAugspurger TomAugspurger merged commit da04c9a into pandas-dev:1.0.x Jan 14, 2020
@simonjayhawkins
Copy link
Member

@TomAugspurger should the auto-backport kick-in moreless straight-away

@TomAugspurger
Copy link
Contributor

Oh, whoops, this was merged to the wrong branch. PRs should go to master.

@TomAugspurger
Copy link
Contributor

So, I think I will revert this, make a new PR to master, and then use the bot to backport it... Probably not necessary, but let's do it to not mess up history / branching.

TomAugspurger added a commit that referenced this pull request Jan 14, 2020
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Jan 14, 2020
TomAugspurger added a commit that referenced this pull request Jan 14, 2020
@TomAugspurger
Copy link
Contributor

OK, reverted on 1.0.x, and made #31003 to master (which will be backported).

@tsvikas
Copy link
Contributor Author

tsvikas commented Jan 14, 2020

I thought we need to work on the development branch, and bit on master. Hmmm. How axtually do you manage your Branch's in pandas?

@jorisvandenbossche
Copy link
Member

I thought we need to work on the development branch, and bit on master. Hmmm. How axtually do you manage your Branch's in pandas?

Everything is merged in master, and the appropriate commits for 1.0.0 are backported into the 1.0.x branch. So in practice, almost all PRs should target the master branch.

@tsvikas tsvikas deleted the docs-na-values branch February 3, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants