Skip to content

[BUG] -1 to the power of pd.NA was returning -1 #30960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

[BUG] -1 to the power of pd.NA was returning -1 #30960

merged 1 commit into from
Jan 13, 2020

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jan 13, 2020 •
edited
Loading

@MarcoGorelli MarcoGorelli changed the title 🐛 -1 to the power of pd.NA was returning -1 [BUG] -1 to the power of pd.NA was returning -1 Jan 13, 2020
@simonjayhawkins simonjayhawkins added this to the 1.0.0 milestone Jan 13, 2020
@simonjayhawkins simonjayhawkins added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Numeric Operations Arithmetic, Comparison, and Logical operations labels Jan 13, 2020
@MarcoGorelli
Copy link
Member Author

##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes. For more information, see https://go.microsoft.com/fwlink/?linkid=2077134

I don't know what to make of this error, sorry

jorisvandenbossche
jorisvandenbossche approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonjayhawkins
Copy link
Member

@jorisvandenbossche in these situations is a whatsnew note needed?

@jorisvandenbossche
Copy link
Member

That's not needed in this case, since it is a new feature, not a bugfix compared to a previous release.

@simonjayhawkins
Copy link
Member

although it's a user reported bug from the rc release. could be worth considering in future having a short section in the whatsnew listing changes since the rc.

@TomAugspurger
Copy link
Contributor

I think we're OK without one.

@TomAugspurger TomAugspurger merged commit 7ba53f0 into pandas-dev:master Jan 13, 2020
@TomAugspurger
Copy link
Contributor

Thanks @MarcoGorelli!

sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Jan 13, 2020
@sthagen
Merge pull request #9 from pandas-dev/master
0182e3f 
BUG: -1 to the power of pd.NA was returning -1 (pandas-dev#30960)
@jorisvandenbossche
Copy link
Member

@meeseeksdev backport 1.0.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 13, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 13, 2020
@MarcoGorelli @meeseeksmachine
Backport PR pandas-dev#30960: [BUG] -1 to the power of pd.NA was retu…
0d52a54 
…rning -1
@jorisvandenbossche
Copy link
Member

For some reason this got not backported (we will need to check it a bit ...)

jorisvandenbossche pushed a commit that referenced this pull request Jan 13, 2020
@meeseeksmachine @MarcoGorelli @jorisvandenbossche
Backport PR #30960: [BUG] -1 to the power of pd.NA was returning -1 (#…
1bac95c 
…30983)

Co-authored-by: Marco Gorelli <[email protected]>
@MarcoGorelli MarcoGorelli deleted the minus-one-to-pd-na branch February 25, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

BUG: rpow with -1 and pd.NA should return pd.NA
4 participants
@MarcoGorelli @simonjayhawkins @jorisvandenbossche @TomAugspurger