TYP: NDFrame.resample #30947
Merged
TYP: NDFrame.resample #30947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Jan 13, 2020
| @@ -5777,13 +5777,14 @@ def groupby( | |||
| group_keys: bool = True, | |||
| squeeze: bool = False, | |||
| observed: bool = False, | |||
| ) -> "groupby_generic.DataFrameGroupBy": | |||
| ) -> "DataFrameGroupBy": | |||
| from pandas.core.groupby.generic import DataFrameGroupBy | |||
There was a problem hiding this comment.
Can this no longer be done at the top of the module rather than in the function?
There was a problem hiding this comment.
Its not a good idea to import the class at the top because of circular import problems.
There was a discussion in #30314 if the import could be less ugly (generic_groupby is not a module name). This is an attempt to improve on that and makes the import for groupbys and resample more similar to each other.
There was a problem hiding this comment.
Gotcha. Generally not a fan of this but I guess somewhat orthogonal
WillAyd
approved these changes
Jan 13, 2020
| @@ -5777,13 +5777,14 @@ def groupby( | |||
| group_keys: bool = True, | |||
| squeeze: bool = False, | |||
| observed: bool = False, | |||
| ) -> "groupby_generic.DataFrameGroupBy": | |||
| ) -> "DataFrameGroupBy": | |||
| from pandas.core.groupby.generic import DataFrameGroupBy | |||
There was a problem hiding this comment.
Gotcha. Generally not a fan of this but I guess somewhat orthogonal
|
Thanks @topper-123 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR types up the method
NDFrame.resample.Also renames the func
resampletoget_resamplerand import the groupby types used for type checking in frame.py/series.py undir theif TYPE_CHECKING:clause.