Skip to content

BUG: EAs should not be hashable #30908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2020
Merged

BUG: EAs should not be hashable #30908

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f92a39d
BUG: EAs should not be hashable
jbrockmendel Jan 11, 2020
22b0872
Merge branch 'master' of https://github.com/pandas-dev/pandas into bu…
jbrockmendel Jan 19, 2020
3851d90
docstring
jbrockmendel Jan 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/core/arrays/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,6 +1073,9 @@ def _reduce(self, name, skipna=True, **kwargs):
"""
raise TypeError(f"cannot perform {name} with type {self.dtype}")

def __hash__(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may want to add some text to the top of the EA that says EA by default are not hashable

raise TypeError(f"unhashable type: {repr(type(self).__name__)}")


class ExtensionOpsMixin:
"""
Expand Down
5 changes: 5 additions & 0 deletions pandas/tests/extension/base/methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,11 @@ def test_shift_fill_value(self, data):
expected = data.take([2, 3, 0, 0])
self.assert_extension_array_equal(result, expected)

def test_not_hashable(self, data):
# We are in general mutable, so not hashable
with pytest.raises(TypeError, match="unhashable type"):
hash(data)

def test_hash_pandas_object_works(self, data, as_frame):
# https://github.com/pandas-dev/pandas/issues/23066
data = pd.Series(data)
Expand Down