Skip to content

BUG: SystemError in df.sum #30905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

BUG: SystemError in df.sum #30905

merged 1 commit into from
Jan 15, 2020

Conversation

jbrockmendel
Copy link
Member

@WillAyd
Copy link
Member

WillAyd commented Jan 10, 2020

Hmm that's strange. Is there an upstream issue for this?

@jbrockmendel
Copy link
Member Author

@scoder any idea if this is an issue in cython vs further upstream?

@gfyoung gfyoung added Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version Datetime Datetime data dtype labels Jan 11, 2020
@jbrockmendel jbrockmendel mentioned this pull request Jan 12, 2020
Closed
@TomAugspurger TomAugspurger added this to the 1.0.0 milestone Jan 14, 2020
@TomAugspurger
Copy link
Contributor

Planning to merge this later today.

@WillAyd
Copy link
Member

WillAyd commented Jan 14, 2020

No issues in merging but if this is the resolution I guess the question is do we need to worry about this in other places where Cython / f-strings are used?

@TomAugspurger
Copy link
Contributor

Something to keep an eye on / debug for sure. I'm not really sure where to start on that (the linked issue has a bit more information). Disallowing fstrings in Cython code is certainly one option.

@TomAugspurger TomAugspurger merged commit 9a68635 into pandas-dev:master Jan 15, 2020
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 15, 2020
@jbrockmendel @meeseeksmachine
Backport PR pandas-dev#30905: BUG: SystemError in df.sum
f5ceb0e
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 15, 2020
Merged
@TomAugspurger
Copy link
Contributor

Thanks @jbrockmendel!

simonjayhawkins pushed a commit that referenced this pull request Jan 15, 2020
@meeseeksmachine @jbrockmendel @simonjayhawkins
Backport PR #30905: BUG: SystemError in df.sum (#31044)
206cc3e 
Co-authored-by: jbrockmendel <[email protected]>
@jbrockmendel jbrockmendel deleted the reg-dfadd branch January 15, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Datetime Datetime data dtype Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Regression in DataFrame.sum with mixed datetime, numeric and missing values
4 participants
@jbrockmendel @WillAyd @TomAugspurger @gfyoung