Skip to content

DOC: Move import conventions from wiki to docs #30808 #30888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

souvik3333
Copy link
Contributor

@souvik3333
Copy link
Contributor Author

@datapythonista I was looking into testing files and there all imports are absolute but previously (according to wiki) explicit relative imports were encouraged. Are absolute imports encouraged in test files also?

@datapythonista
Copy link
Member

Lots of people contribute to pandas, so if we don't enforce the policies with validation in the CI, you'll find any possible kind of practice in the code base. I think the preferred option is using absolute imports, so for now, if you can move that policy to the docs, that's a first step. Then, we may considering if its worth detecting relative imports, fixing them, and validating in the CI that they are not reintroduced. Feel free to open an issue to discuss that after this is closed.

@souvik3333
Copy link
Contributor Author

@datapythonista, I have updated the docs. Let me know if there should be any changes.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @simonjayhawkins do you want to have a look?

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jan 13, 2020
@simonjayhawkins simonjayhawkins merged commit bbccf2d into pandas-dev:master Jan 13, 2020
@simonjayhawkins
Copy link
Member

Thanks @souvik3333

@datapythonista
Copy link
Member

Thanks both, I deleted the wiki page.

@souvik3333 souvik3333 deleted the update-doc branch January 13, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Move import conventions from wiki to docs
3 participants