CLN: misc cleanups

pandas/_libs/index.pyx

@@ -85,7 +85,6 @@ cdef class IndexEngine:
         """
         cdef:
             object loc
-            void* data_ptr
 
         loc = self.get_loc(key)
         if isinstance(loc, slice) or util.is_array(loc):
@@ -101,7 +100,6 @@ cdef class IndexEngine:
         """
         cdef:
             object loc
-            void* data_ptr
 
         loc = self.get_loc(key)
         value = convert_scalar(arr, value)

pandas/core/arrays/categorical.py

@@ -2279,7 +2279,7 @@ def _from_factorized(cls, uniques, original):
             original.categories.take(uniques), dtype=original.dtype
         )
 
-    def equals(self, other):
+    def equals(self, other) -> bool:
         """
         Returns True if categorical arrays are equal.
 

pandas/core/generic.py

@@ -1347,7 +1347,7 @@ def _indexed_same(self, other) -> bool:
             self._get_axis(a).equals(other._get_axis(a)) for a in self._AXIS_ORDERS
         )
 
-    def equals(self, other):
+    def equals(self, other) -> bool_t:
         """
         Test whether two objects contain the same elements.
 

pandas/core/indexes/datetimelike.py

@@ -153,16 +153,14 @@ def equals(self, other) -> bool:
         return np.array_equal(self.asi8, other.asi8)
 
     @Appender(_index_shared_docs["contains"] % _index_doc_kwargs)
-    def __contains__(self, key):
+    def __contains__(self, key) -> bool:
         try:
             res = self.get_loc(key)
-            return (
-                is_scalar(res)
-                or isinstance(res, slice)
-                or (is_list_like(res) and len(res))
-            )
         except (KeyError, TypeError, ValueError):
             return False
+        return bool(
+            is_scalar(res) or isinstance(res, slice) or (is_list_like(res) and len(res))
+        )
 
     # Try to run function on index first, and then on elements of index
     # Especially important for group-by functionality
@@ -875,11 +873,7 @@ def _is_convertible_to_index_for_join(cls, other: Index) -> bool:
 
     def _wrap_joined_index(self, joined, other):
         name = get_op_result_name(self, other)
-        if (
-            isinstance(other, type(self))
-            and self.freq == other.freq
-            and self._can_fast_union(other)
-        ):
+        if self._can_fast_union(other):
             joined = self._shallow_copy(joined)
             joined.name = name
             return joined

pandas/core/indexes/range.py

@@ -441,7 +441,7 @@ def argsort(self, *args, **kwargs):
         else:
             return np.arange(len(self) - 1, -1, -1)
 
-    def equals(self, other):
+    def equals(self, other) -> bool:
         """
         Determines if two Index objects contain the same elements.
         """

pandas/core/internals/managers.py

@@ -1394,7 +1394,7 @@ def take(self, indexer, axis=1, verify=True, convert=True):
             new_axis=new_labels, indexer=indexer, axis=axis, allow_dups=True
         )
 
-    def equals(self, other):
+    def equals(self, other) -> bool:
         self_axes, other_axes = self.axes, other.axes
         if len(self_axes) != len(other_axes):
             return False