Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: Added DataFrame.compare and Series.compare (GH30429) #30852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Added DataFrame.compare and Series.compare (GH30429) #30852
Changes from all commits
c13af19
8f5d0fb
c5b793a
5eff415
0bc8529
d22e21a
83f31df
488c8a8
322ff20
71f5eef
e50172c
4a82bec
b2849ed
8e0e441
ff7a572
bc969e8
26c6ca6
de2195b
5fb2edc
dcc2d71
35ccb5f
586e37c
d13db2f
5342208
35e9be6
77b1c9e
51ffe0e
71b0332
827b69c
53918a5
110f138
acd51e0
1ef31c9
a898b87
3bc7485
36024d5
06ed216
e4729ca
b6c0f78
c352ee2
0850420
a709db7
9509604
e1a1c49
a8caa53
4056f90
e50772d
39f857e
d0226d8
6c62b0e
098d40c
131ea95
4223eb4
c5246d6
91758c8
7dde706
774ff5d
eb6d33d
5d34fc4
c358e3d
0189623
b0b3e24
cdb03b2
007eeb7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does keep_equal make sense w/o keep_shape==True? IOW does it stand on its own? can you add an example of just using it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I would say so. It helps identify which one could be the "anomaly". I myself have come across such use cases.
For example, say I'm looking at the date a company publishes 2 types of their quarterly report.
By comparing the two, I can see that the discrepancy is in 2015 and 2016, but I don't know which one deviated from the norm.
The natural thing for me to do now is look at 2015 Q2_filing and 2016 Q1_filing where they agree with each other. (You can of course look at the whole thing but sometimes data is too big and I just want to take a look at the relevant ones first)
With this result I know probably something is off for the second type of reports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added the example in frame.py.
keep_equal
does not stand on its own forSeries
so I did not add anything there.