Skip to content

BUG: Handle nested arrays in array_equivalent_object #30842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Jan 9, 2020

@@ -1074,6 +1074,7 @@ Other
- Bug in :class:`DataFrame` constructor when passing a 2D ``ndarray`` and an extension dtype (:issue:`12513`)
- Bug in :meth:`DaataFrame.to_csv` when supplied a series with a ``dtype="string"`` and a ``na_rep``, the ``na_rep`` was being truncated to 2 characters. (:issue:`29975`)
- Bug where :meth:`DataFrame.itertuples` would incorrectly determine whether or not namedtuples could be used for dataframes of 255 columns (:issue:`28282`)
- Handle nested NumPy ``object`` arrays in :func:`~pandas/core/dtypes/missing.array_equivalent` (:issue:`30841`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This :func: link will not work (and it's also not a public function anyway), but I think you can mention it is in the pandas.testing.assert_frame/series_equal methods, as it is there eventually this array_equivalent is being used?

@TomAugspurger TomAugspurger merged commit da10947 into pandas-dev:master Jan 9, 2020
@TomAugspurger
Copy link
Contributor

Thanks!

@TomAugspurger TomAugspurger added this to the 1.0 milestone Jan 9, 2020
@TomAugspurger TomAugspurger added ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite labels Jan 9, 2020
@xhochy xhochy deleted the issue-30841 branch January 9, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestBaseCasting.test_to_numpy fails for ExtensionArrays that yield nested numpy arrays
3 participants