Skip to content

BUG: added missing fill_na parameter to DataFrame.unstack() with list of levels #30838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jan 9, 2020

Conversation

tanmay1618
Copy link
Contributor

@tanmay1618 tanmay1618 commented Jan 9, 2020

@pep8speaks
Copy link

pep8speaks commented Jan 9, 2020

Hello @tanmay1618! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-09 18:09:40 UTC

@WillAyd
Copy link
Member

WillAyd commented Jan 9, 2020

Thanks for the PR. Does this fix a particular issue? If so will want to add tests first and foremost

@tanmay1618
Copy link
Contributor Author

tanmay1618 commented Jan 9, 2020

Yes, it fixes this issue. #30740. Sure, I will add tests for this.

@simonjayhawkins
Copy link
Member

@tanmay1618 Thanks for the PR. generally lgtm. can you add a whatsnew under bugfixes.

@simonjayhawkins simonjayhawkins added Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Jan 9, 2020
@simonjayhawkins simonjayhawkins changed the title added missing fill_na parameter BUG: added missing fill_na parameter to DataFrame.unstack() with list of levels Jan 9, 2020
@tanmay1618
Copy link
Contributor Author

getting this error on running tests

pandas/__init__.py:54: in <module>
    from pandas.core.api import (
pandas/core/api.py:4: in <module>
    from pandas._libs.missing import NA
E   ImportError: cannot import name 'NA' from 'pandas._libs.missing'

@TomAugspurger
Copy link
Contributor

@tanmay1618 you probably need to rebuild the C extensions. python setup.py build_ext -i.

@TomAugspurger TomAugspurger added this to the 1.0 milestone Jan 9, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanmay1618 for the changes. a few nits. ping on green

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanmay1618 for this PR. lgtm pending green.

@tanmay1618
Copy link
Contributor Author

@simonjayhawkins Thanks for all the help, change requests and helping out through the PR. The checks are all green, now.

@tanmay1618
Copy link
Contributor Author

@TomAugspurger Thanks for all your suggestions and help as well.

@TomAugspurger TomAugspurger merged commit feaa503 into pandas-dev:master Jan 9, 2020
@TomAugspurger
Copy link
Contributor

Thanks @tanmay1618!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.unstack() with list of levels ignores fill_value
5 participants