-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: added missing fill_na parameter to DataFrame.unstack() with list of levels #30838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @tanmay1618! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-01-09 18:09:40 UTC |
Thanks for the PR. Does this fix a particular issue? If so will want to add tests first and foremost |
Yes, it fixes this issue. #30740. Sure, I will add tests for this. |
Co-Authored-By: Simon Hawkins <[email protected]>
@tanmay1618 Thanks for the PR. generally lgtm. can you add a whatsnew under bugfixes. |
…into unstack_fill_na
getting this error on running tests
|
…into unstack_fill_na
…into unstack_fill_na
…into unstack_fill_na
@tanmay1618 you probably need to rebuild the C extensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tanmay1618 for the changes. a few nits. ping on green
Co-Authored-By: Simon Hawkins <[email protected]>
Co-Authored-By: Simon Hawkins <[email protected]>
Co-Authored-By: Simon Hawkins <[email protected]>
Co-Authored-By: Simon Hawkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tanmay1618 for this PR. lgtm pending green.
@simonjayhawkins Thanks for all the help, change requests and helping out through the PR. The checks are all green, now. |
@TomAugspurger Thanks for all your suggestions and help as well. |
Thanks @tanmay1618! |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff