Skip to content

CLN: Removed "# noqa: F401" comments #30832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

CLN: Removed "# noqa: F401" comments #30832

merged 1 commit into from
Jan 9, 2020

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Jan 9, 2020 •
edited
Loading

Implemented __all__ for each changed file

Removed "# noqa: F401" comments
cff3aef 
Implemented __all__ for each changed file
@jreback jreback added the Code Style Code style, linting, code_checks label Jan 9, 2020
@jreback jreback added this to the 1.0 milestone Jan 9, 2020
@jreback jreback merged commit 2c4df98 into pandas-dev:master Jan 9, 2020
@jreback
Copy link
Contributor

jreback commented Jan 9, 2020

nice. thanks @MomIsBestFriend

mroeschke
mroeschke reviewed Jan 9, 2020
View reviewed changes
pandas/api/indexers/__init__.py
Public API for Rolling Window Indexers.
"""

from pandas.core.indexers import check_bool_array_indexer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jbrockmendel was this function added here recently?

I think check_bool_array_indexer is conceptually different from what should belong in this file. This api.indexers was intended to be for creating indexers to support rolling, groupby etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was a recent PR by @TomAugspurger

Copy link
Contributor

@TomAugspurger TomAugspurger Jan 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was added in #30308. See the conversation starting around #30308 (comment). Do you have a better home you'd recommend @mroeschke?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the method seems ExtensionArray related, thought it could have belonged in api.extensions.

Agreed that api.indexers isn't the best name. I can put in a PR tonight clarifying (e.g.api.grouping_indexers or something)

@ShaharNaveh ShaharNaveh deleted the CLN-__all__ branch January 10, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@jbrockmendel jbrockmendel jbrockmendel left review comments

@mroeschke mroeschke mroeschke left review comments

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ShaharNaveh @jreback @TomAugspurger @jbrockmendel @mroeschke