Tests for Deprecate SparseArray for python 3.6 and 3.7 and fixes to other deprecation tests

pandas/__init__.py

@@ -319,11 +319,37 @@ def __getattr__(self, item):
             except AttributeError:
                 raise AttributeError(f"module datetime has no attribute {item}")
 
-    datetime = __Datetime().datetime
+    datetime = __Datetime()
 
-    class SparseArray:
-        pass
+    class __SparseArray(pandas.core.arrays.sparse.SparseArray):
+        def __warnSparseArray(self):
+            import warnings
+
+            warnings.warn(
+                "The pandas.SparseArray class is deprecated "
+                "and will be removed from pandas in a future version. "
+                "Use pandas.arrays.SparseArray instead.",
+                FutureWarning,
+                stacklevel=3,
+            )
 
+        def __init__(
+            self,
+            data,
+            sparse_index=None,
+            index=None,
+            fill_value=None,
+            kind="integer",
+            dtype=None,
+            copy=False,
+        ):
+            self.__warnSparseArray()
+            super().__init__(data, sparse_index, index, fill_value, kind, dtype, copy)
+
+        def __getattr__(self, name):
+            return super().__getattribute__(name)
+
+    SparseArray = __SparseArray
 
 # module level doc-string
 __doc__ = """

pandas/tests/api/test_api.py

@@ -43,7 +43,7 @@ class TestPDApi(Base):
     ]
 
     # these are already deprecated; awaiting removal
-    deprecated_modules: List[str] = []
+    deprecated_modules: List[str] = ["np", "datetime"]
 
     # misc
     misc = ["IndexSlice", "NaT", "NA"]
@@ -90,15 +90,17 @@ class TestPDApi(Base):
         "UInt64Dtype",
         "NamedAgg",
     ]
-    if not compat.PY37:
-        classes.extend(["Panel", "SparseSeries", "SparseDataFrame", "SparseArray"])
-        deprecated_modules.extend(["np", "datetime"])
 
     # these are already deprecated; awaiting removal
     deprecated_classes: List[str] = []
 
     # these should be deprecated in the future
-    deprecated_classes_in_future: List[str] = []
+    deprecated_classes_in_future: List[str] = ["SparseArray"]
+
+    if not compat.PY37:
+        classes.extend(["Panel", "SparseSeries", "SparseDataFrame"])
+        # deprecated_modules.extend(["np", "datetime"])
+        # deprecated_classes_in_future.extend(["SparseArray"])
 
     # external modules exposed in pandas namespace
     modules: List[str] = []
@@ -201,41 +203,46 @@ class TestPDApi(Base):
 
     def test_api(self):
 
-        self.check(
-            pd,
+        checkthese = (
             self.lib
             + self.misc
             + self.modules
-            + self.deprecated_modules
             + self.classes
-            + self.deprecated_classes
-            + self.deprecated_classes_in_future
             + self.funcs
             + self.funcs_option
             + self.funcs_read
             + self.funcs_json
             + self.funcs_to
-            + self.deprecated_funcs_in_future
-            + self.deprecated_funcs
-            + self.private_modules,
-            self.ignored,
+            + self.private_modules
         )
+        if not compat.PY37:
+            checkthese.extend(
+                self.deprecated_modules
+                + self.deprecated_classes
+                + self.deprecated_classes_in_future
+                + self.deprecated_funcs_in_future
+                + self.deprecated_funcs
+            )
+        self.check(pd, checkthese, self.ignored)
 
     def test_depr(self):
-        deprecated = (
+        deprecated_list = (
             self.deprecated_modules
             + self.deprecated_classes
             + self.deprecated_classes_in_future
             + self.deprecated_funcs
             + self.deprecated_funcs_in_future
         )
-        for depr in deprecated:
+        for depr in deprecated_list:
             with tm.assert_produces_warning(FutureWarning):
                 if compat.PY37:
                     getattr(pd, depr)
                 elif depr == "datetime":
                     deprecated = getattr(pd, "__Datetime")
-                    deprecated().__getattr__(dir(pd.datetime)[-1])
+                    deprecated().__getattr__(dir(pd.datetime.datetime)[-1])
+                elif depr == "SparseArray":
+                    deprecated = getattr(pd, depr)
+                    deprecated([])
                 else:
                     deprecated = getattr(pd, depr)
                     deprecated.__getattr__(dir(deprecated)[-1])
@@ -245,9 +252,10 @@ def test_datetime():
     from datetime import datetime
     import warnings
 
-    with warnings.catch_warnings():
-        warnings.simplefilter("ignore", FutureWarning)
-        assert datetime(2015, 1, 2, 0, 0) == pd.datetime(2015, 1, 2, 0, 0)
+    if compat.PY37:
+        with warnings.catch_warnings():
+            warnings.simplefilter("ignore", FutureWarning)
+            assert datetime(2015, 1, 2, 0, 0) == pd.datetime(2015, 1, 2, 0, 0)
 
 
 def test_np():