Skip to content

PERF: cache IntervalIndex._ndarray_values #30797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

PERF: cache IntervalIndex._ndarray_values #30797

merged 1 commit into from
Jan 7, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 7, 2020 •
edited by jreback
Loading

closes #30742

TomAugspurger
TomAugspurger approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

There was also the issue of Index._ndarray_values being slower than Categorical._ndarray_values, due to a few dtype checks: #30742 (comment). Can you check the timing of IntervalIndex._ndarray_values vs. IntervalArray._ndarray_values on this branch?

@jreback jreback added Interval Interval data type Performance Memory or execution speed performance labels Jan 7, 2020
@jreback jreback added this to the 1.0 milestone Jan 7, 2020
@jreback jreback merged commit 425c2fb into pandas-dev:master Jan 7, 2020
@jreback
Copy link
Contributor

jreback commented Jan 7, 2020

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the perf-ii branch January 7, 2020 23:04
@jorisvandenbossche
Copy link
Member

Thanks @jbrockmendel !

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Interval Interval data type Performance Memory or execution speed performance
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

PERF: regression in getattr for IntervalIndex
4 participants
@jbrockmendel @jreback @jorisvandenbossche @TomAugspurger