BUG: TDI/DTI _shallow_copy creating invalid arrays #30764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 7, 2020
| @@ -29,6 +29,25 @@ def test_freq_validation_with_nat(self, dt_cls): | |||
| with pytest.raises(ValueError, match=msg): | |||
| dt_cls([pd.NaT, pd.Timestamp("2011-01-01").value], freq="D") | |||
|
|
|||
| # TODO: better place for tests shared by DTI/TDI? | |||
There was a problem hiding this comment.
make indexes/datetimelike (there is a datetimelike.py now though)?
jreback
reviewed
Jan 7, 2020
| pd.timedelta_range("1 Day", periods=5), | ||
| ], | ||
| ) | ||
| def test_shallow_copy_inherits_array_freq(self, index): |
There was a problem hiding this comment.
note that we appear to have very limited shallow_copy tests now :-> so this is good
jreback
added
ExtensionArray
|
thanks, some comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this we should be able to use shallow_copy in indexes.extension more, which will help with perf (xref #30717)