Fix PeriodIndex._shallow_copy allowing object-dtype #30713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Constructors
jreback
reviewed
Jan 5, 2020
| # I think that once all of Datetime* are EAs, we can simplify | ||
| # this quite a bit. | ||
| values = period_array(values, freq=self.freq) | ||
| raise TypeError(type(values), getattr(values, "dtype", None)) |
There was a problem hiding this comment.
After this PR, this is never reached. In master we get there with ndarray[object] via dropna and symmetric_difference. The PeriodIndex set ops PRs over the last couple days have been aimed at this
There was a problem hiding this comment.
ok can u make a comment about this then
should this just be an assertion ?
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.