CLN: replacing '.format' with f-strings in various files #30706
Conversation
|
Hello @AlfredoGJ! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-01-06 16:14:06 UTC |
AlfredoGJ
changed the title
scripts/validate_docstrings.py
Outdated
| title_line = "{side} {title}{adj} {side}".format( | ||
| side=char * side_len, title=title, adj=adj | ||
| ) | ||
| title_line = f"{char * side_len} {title}{adj} {side}" |
There was a problem hiding this comment.
Replace the {side} (at the very end) with {char * side_len} 😄
There was a problem hiding this comment.
Now I see, thank you.
There was a problem hiding this comment.
@AlfredoGJ Thanks for the PR. some minor nits otherwise lgtm.
pandas/tseries/holiday.py
Outdated
| "Holiday Calendar {name} does not have any " | ||
| "rules specified".format(name=self.name) | ||
| f"Holiday Calendar {self.name} does not have any " | ||
| f"rules specified" |
There was a problem hiding this comment.
f string prefix not needed here
| f"rules specified" | |
| "rules specified" |
| "`requirements-dev.txt` has to be generated with `{}` after " | ||
| "`environment.yml` is modified.\n".format(sys.argv[0]) | ||
| f"`requirements-dev.txt` has to be generated with `{sys.argv[0]}` after " | ||
| f"`environment.yml` is modified.\n" |
There was a problem hiding this comment.
Thanks for your feedback, I just changed it
| ) | ||
| if args.azure: | ||
| msg = ( | ||
| "##vso[task.logissue type=error;" | ||
| "sourcepath=requirements-dev.txt]{}".format(msg) | ||
| f"##vso[task.logissue type=error;" |
There was a problem hiding this comment.
Thanks @AlfredoGJ, just one small thing, and this can be merged.
pandas/tseries/holiday.py
Outdated
| @@ -394,8 +394,7 @@ def holidays(self, start=None, end=None, return_name=False): | |||
| """ | |||
| if self.rules is None: | |||
| raise Exception( | |||
| "Holiday Calendar {name} does not have any " | |||
| "rules specified".format(name=self.name) | |||
| f"Holiday Calendar {self.name} does not have any " "rules specified" | |||
There was a problem hiding this comment.
You'll have to join these two strings
There was a problem hiding this comment.
Thanks for the feedback
|
thanks @AlfredoGJ |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff