Skip to content

REF: Share _fast_union between DTI/TDI #30704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2020
Merged

REF: Share _fast_union between DTI/TDI #30704

merged 2 commits into from
Jan 5, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

jreback
jreback approved these changes Jan 5, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment for follow up

pandas/core/indexes/datetimelike.py
if self[0] <= other[0]:
left, right = self, other
elif sort is False:
# TDIs are not in the "correct" order and we don't want
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment could be more generic (TDI)

@jreback jreback added the Index Related to the Index class or subclasses label Jan 5, 2020
@jreback jreback added this to the 1.0 milestone Jan 5, 2020
@jreback jreback merged commit 1dcf9ca into pandas-dev:master Jan 5, 2020
@jbrockmendel jbrockmendel deleted the share-delete branch January 5, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback