Skip to content

Fix integer check; also add column with integer name in test case. #30698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

Fix integer check; also add column with integer name in test case. #30698

merged 1 commit into from
Jan 4, 2020

Conversation

hwalinga
Copy link
Contributor

@hwalinga hwalinga commented Jan 4, 2020

A small embarrassing mistake is corrected here that was introduced in the recently merged #28215

@hwalinga hwalinga mentioned this pull request Jan 4, 2020
Merged
5 tasks
@alimcmaster1 alimcmaster1 added the Typing type annotations, mypy/pyright type checking label Jan 4, 2020
@alimcmaster1
Copy link
Member

alimcmaster1 commented Jan 4, 2020 •
edited
Loading

Looks like this fixes CI on master - running my pandas - currently seeing:

pandas/core/generic.py:464: error: Non-overlapping identity check (left operand type: "str", right operand type: "Type[int]")

@topper-123 topper-123 mentioned this pull request Jan 4, 2020
Merged
@alimcmaster1 alimcmaster1 mentioned this pull request Jan 4, 2020
Merged
5 tasks
@jreback jreback added this to the 1.0 milestone Jan 4, 2020
@jreback jreback merged commit 7595313 into pandas-dev:master Jan 4, 2020
@jreback
Copy link
Contributor

jreback commented Jan 4, 2020

thanks for he quick fix @hwalinga

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hwalinga @alimcmaster1 @jreback