Implement PeriodIndex.difference without object-dtype cast #30697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 4, 2020
pandas/_testing.py
Outdated
| @@ -619,7 +619,10 @@ def _get_ilevel_values(index, level): | |||
| # accept level number only | |||
| unique = index.levels[level] | |||
| level_codes = index.codes[level] | |||
| filled = take_1d(unique.values, level_codes, fill_value=unique._na_value) | |||
| if is_extension_array_dtype(unique): | |||
There was a problem hiding this comment.
this is not as nice (though its only for testing), won't unique.take(...) work here?
There was a problem hiding this comment.
Turns out this unique.take(...) wont work here. the trouble is that we are calling _shallow_copy below (presumably for perf) and using unique.take ends up passing the wrong types to shallow_copy
There was a problem hiding this comment.
using unique.take ends up passing the wrong types to shallow_copy
then i'd rather not change this, take_1d just does the right thing, so why change it?
There was a problem hiding this comment.
Looks like passing unique._values instead of unique.values fixes the problem cleanly
jreback
added
Period
jreback
approved these changes
Jan 4, 2020
|
lgtm ping on green. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #30666. After this we'll be able to share some code between the set operations.
The edit in pd._testing is mostly unrelated. Both are motivated by tracking down the places where object-dtype ndarray is passed to PeriodIndex._shallow_copy.