Skip to content

REF: share delete between DTI/TDI/PI #30695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2020
Merged

REF: share delete between DTI/TDI/PI #30695

merged 2 commits into from
Jan 4, 2020

Conversation

jbrockmendel
Copy link
Member

Besides de-duplicating, this moves the ball down the field in getting rid of PeriodIndex._shallow_copy cases where we pass an object ndarray

@jreback jreback added Index Related to the Index class or subclasses Refactor Internal refactoring of code labels Jan 4, 2020
@jreback jreback added this to the 1.0 milestone Jan 4, 2020
jreback
jreback approved these changes Jan 4, 2020
View reviewed changes
pandas/core/indexes/datetimelike.py
# --------------------------------------------------------------------
# List-like Methods

def delete(self, loc):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type if you can

@jreback jreback merged commit be1a62d into pandas-dev:master Jan 4, 2020
@jreback
Copy link
Contributor

jreback commented Jan 4, 2020

thxs

@jbrockmendel jbrockmendel deleted the ref-delete2 branch January 4, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Refactor Internal refactoring of code
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback