Skip to content

Fix errors='ignore' being ignored in astype #30324 #30670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Fix errors='ignore' being ignored in astype #30324 #30670

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
adca461
Merge pull request #1 from pandas-dev/master
naomi172839 Dec 26, 2019
ffdc947
Fixed errors='ignore' being ignored
naomi172839 Jan 4, 2020
c88b98e
Added comments to the tests. Test is already in place, unsure why it…
naomi172839 Jan 8, 2020
b73279e
Added a test for a not covered case. Added whats new entry.
naomi172839 Jan 9, 2020
88aa2f3
Updated whatsnew to the latest version, added my own whatsnew entry
naomi172839 Jan 9, 2020
79ff6e3
Fix whats new entry
naomi172839 Mar 4, 2020
0cd4929
Fix whats new entry
naomi172839 Mar 5, 2020
94eb49e
Trying again to fix whats new entry
naomi172839 Mar 5, 2020
061e02a
Updated file permissions
naomi172839 Mar 5, 2020
7a76a71
Trying yet again to fix the whatsnew
naomi172839 Mar 5, 2020
1272c8a
Tried downloading directly from github.
naomi172839 Mar 5, 2020
5010732
Tried downloading directly from github.
naomi172839 Mar 5, 2020
bee2222
Merge remote-tracking branch 'upstream/master' into #30324
WillAyd Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5576,7 +5576,7 @@ def astype(self, dtype, copy: bool_t = True, errors: str = "raise"):
"""
if is_dict_like(dtype):
if self.ndim == 1: # i.e. Series
if len(dtype) > 1 or self.name not in dtype:
if len(dtype) > 1 or self.name not in dtype and errors == "raise":
raise KeyError(
"Only the Series name can be used for "
"the key in Series dtype mappings."
Expand All @@ -5585,7 +5585,7 @@ def astype(self, dtype, copy: bool_t = True, errors: str = "raise"):
return self.astype(new_type, copy, errors)

for col_name in dtype.keys():
if col_name not in self:
if col_name not in self and errors == "raise":
raise KeyError(
"Only a column name can be used for the "
"key in a dtype mappings argument."
Expand Down