Skip to content

CI: unpin IPython #30665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

CI: unpin IPython #30665

merged 1 commit into from
Jan 4, 2020

Conversation

TomAugspurger
Copy link
Contributor

Closes #30537

@jbrockmendel
Copy link
Member

LGTM

@WillAyd
Copy link
Member

WillAyd commented Jan 4, 2020

Does it matter this version was released two days ago? I guess IPython is technically a dev dependency so maybe not, but I would think its common enough outside of just pandas development that requiring such a new release could cause inconsistencies with other packages a user may have

@TomAugspurger
Copy link
Contributor Author

This is only for the doc build / dev environment. We haven't changed the requirement for users.

@jreback jreback added the CI Continuous Integration label Jan 4, 2020
@jreback jreback added this to the 1.0 milestone Jan 4, 2020
@jreback jreback merged commit f5d1c5d into pandas-dev:master Jan 4, 2020
@jreback
Copy link
Contributor

jreback commented Jan 4, 2020

thanks @TomAugspurger

the less we pin in ci the better generally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Unpin ipython 7.10.1 once ipython 7.11.1 released
4 participants
@TomAugspurger @jbrockmendel @WillAyd @jreback