TYP: check_untyped_defs io.sas.sasreader #30659
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,24 @@ | ||
| """ | ||
| Read SAS sas7bdat or xport files. | ||
| """ | ||
| from typing import TYPE_CHECKING, AnyStr, Optional, Union | ||
|
|
||
| from pandas._typing import FilePathOrBuffer | ||
|
|
||
| from pandas.io.common import stringify_path | ||
|
|
||
| if TYPE_CHECKING: | ||
| from pandas.io.sas.sas_xport import XportReader # noqa: F401 | ||
| from pandas.io.sas.sas7bdat import SAS7BDATReader # noqa: F401 | ||
|
|
||
|
|
||
| def read_sas( | ||
| filepath_or_buffer: FilePathOrBuffer[AnyStr], | ||
|
There was a problem hiding this comment. maybe we should change the definition in _typing? There was a problem hiding this comment. can you elaborate? There was a problem hiding this comment. FilePathOrBuffer[AnyStr] should be in _typing instead of just the not parametric FilePathOrBuffer There was a problem hiding this comment. for some read/write methods only a string buffer (or bytes buffer) is allowed, i.e. to_html and we need to annotate as FilePathOrBuffer[str] (or FilePathOrBuffer[bytes]) otherwise we get mypy errors. There was a problem hiding this comment. that’s a very limited case compared to the more general which accepts strings and buffers these should be distinct / parametrized not just in this PR - this is my point There was a problem hiding this comment. not sure I understand, AnyStr is a TypeVar and therefore parametrized https://docs.python.org/3/library/typing.html#typing.AnyStr There was a problem hiding this comment. so, you are adding this here, rather than as a generailized soln in _typing. I would think it would be better there than adding to each of the IO readers. There was a problem hiding this comment. i reverted these additions for now to keep this PR focused on the untyped_defs error, #30659 (comment) |
||
| format: Optional[str] = None, | ||
| index=None, | ||
| encoding: Optional[str] = None, | ||
| chunksize: Optional[int] = None, | ||
| iterator: bool = False, | ||
| ): | ||
| """ | ||
| Read SAS files stored as either XPORT or SAS7BDAT format files. | ||
|
|
@@ -63,14 +71,15 @@ def read_sas( | |
| else: | ||
| raise ValueError("unable to infer format of SAS file") | ||
|
|
||
| reader: Union["XportReader", "SAS7BDATReader"] | ||
|
There was a problem hiding this comment. Do these have a shared base class that is directly importable? Seems like this requires a bit of import gymnastics not sure worth it There was a problem hiding this comment. they share abc.Iterable ... pandas\io\sas\sasreader.py:93: error: "Iterator[Any]" has no attribute "read" many options: Use protocol (python 3.8) from typing_extensions we normally try to avoid most of these. There was a problem hiding this comment.
gone with this option. |
||
| if format.lower() == "xport": | ||
| from pandas.io.sas.sas_xport import XportReader # noqa: F811 | ||
|
|
||
| reader = XportReader( | ||
| filepath_or_buffer, index=index, encoding=encoding, chunksize=chunksize | ||
| ) | ||
| elif format.lower() == "sas7bdat": | ||
| from pandas.io.sas.sas7bdat import SAS7BDATReader # noqa: F811 | ||
|
|
||
| reader = SAS7BDATReader( | ||
| filepath_or_buffer, index=index, encoding=encoding, chunksize=chunksize | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
acutally i think you can just import both readers at the top and call it a day.