BUG/ENH: guarantee blocks will upcast as needed, and split as needed #3065
+115
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. a replace on an IntBlock with a float will upcast, it may
yield multiple blocks if the original IntBlock didn't fully replace
small fix in com.mask_missing to guarantee that a bool ndarray is
returned even in the case of a string comparison with a numeric array
(which for some reason numpy returns a single, non-ndarray value)
BUG: py3 issue in com._maybe_promote for recognizing string types on number like dtypes!
jreback
added a commit
that referenced
this pull request
Mar 16, 2013
BUG/ENH: guarantee blocks will upcast as needed, and split as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows #3064 to proceed (e.g. df.replace(0,0.5) will work on an integer dtype)