Skip to content

REF: move EA wrapping/unwrapping to indexes.extensions #30648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2020
Merged

REF: move EA wrapping/unwrapping to indexes.extensions #30648

merged 4 commits into from
Jan 4, 2020

Conversation

jbrockmendel
Copy link
Member

Re-use the comparison method wrapper in CategoricalIndex.

TomAugspurger
TomAugspurger approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Index Related to the Index class or subclasses labels Jan 4, 2020
@jreback jreback added this to the 1.0 milestone Jan 4, 2020
jreback
jreback approved these changes Jan 4, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. some followon comments

pandas/core/indexes/extension.py
@@ -76,3 +82,73 @@ def wrapper(cls):
return cls

return wrapper


def make_wrapped_comparison_op(opname):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point should type these

@jreback jreback merged commit 9bdc58e into pandas-dev:master Jan 4, 2020
@jreback
Copy link
Contributor

jreback commented Jan 4, 2020

thanks

@jbrockmendel jbrockmendel deleted the ref-delegate branch January 4, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Index Related to the Index class or subclasses
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @TomAugspurger