Skip to content

DOC: Change refs in docs from pandas.SparseArray to pandas.arrays.SparseArray #30644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Jan 3, 2020

Change all references in docs to use arrays.SparseArray rather than just SparseArray

@TomAugspurger
Copy link
Contributor

In #30642 I think Jeff was proposing that accessing pandas.SparseArray from the top-level namespace emits a warning.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jan 3, 2020

In #30642 I think Jeff was proposing that accessing pandas.SparseArray from the top-level namespace emits a warning.

Ah, that's a bigger change. I will change all references to pandas.SparseArray in the code to pandas.arrays.SparseArray and add the deprecation warning to pandas.__init__.py

@TomAugspurger
Copy link
Contributor

It's probably worth discussing whether we actually want to do that for 1.0. I'm not sure if it's worth introducing that right now.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jan 3, 2020

@TomAugspurger Well, I have all the changes done and am about to commit. I'll separate it to a different PR, so you can merge this one as is (with the doc changes), and then we can use the new PR to discuss whether we do all those changes.

@Dr-Irv Dr-Irv changed the title DOC: Deprecate pandas.SparseArray DOC: Change refs in docs from pandas.SparseArray to pandas.arrays.SparseArray Jan 3, 2020
@jreback
Copy link
Contributor

jreback commented Jan 4, 2020

It's probably worth discussing whether we actually want to do that for 1.0. I'm not sure if it's worth introducing that right now.

@TomAugspurger not sure what the issue is here. This makes things very consistent with other EA (I agree Categorical is still there, but this makes a good step).

@jreback jreback added Deprecate Functionality to remove in pandas Sparse Sparse Data Type labels Jan 4, 2020
@jreback jreback added this to the 1.0 milestone Jan 4, 2020
@jreback
Copy link
Contributor

jreback commented Jan 4, 2020

I like #30566 better than this.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Jan 4, 2020

I like #30566 better than this.

#30566 has everything this one does, so if we go forward with that, we can close this one.

@jreback
Copy link
Contributor

jreback commented Jan 4, 2020

closing in favor of #30566

@jreback jreback closed this Jan 4, 2020
@Dr-Irv Dr-Irv deleted the issue30642 branch January 6, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Sparse Sparse Data Type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SparseArray not in arrays module - inconsistent with IntegerArray, StringArray, etc.
3 participants