Skip to content

BLD: address build warnings #30639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

xref #30609

@WillAyd
Copy link
Member

WillAyd commented Jan 3, 2020

Nice! Does this address all of them?

@datapythonista
Copy link
Member

Not sure if you've seen it, but besides the failure in the docs, this error is happening lots of times in the tests:

Exception ignored in: 'pandas._libs.window.aggregations.is_monotonic_start_end_bounds'

TypeError: Argument 'arr' has incorrect type (expected numpy.ndarray, got pandas._libs.window.aggregations._memoryviewslice)

@jbrockmendel
Copy link
Member Author

Does this address all of them?

No. Locally (only checked OSX) it addresses the buffer unpacking in aggregations.pyx and the assignment warnings for algos.c. The __pyx_memview_get_object ones I think are coming from an unused import; they dont correspond directly to any of the .pyx code

@alimcmaster1
Copy link
Member

Does this address all of them?

No. Locally (only checked OSX) it addresses the buffer unpacking in aggregations.pyx and the assignment warnings for algos.c. The __pyx_memview_get_object ones I think are coming from an unused import; they dont correspond directly to any of the .pyx code

Nice! What's the best way of figuring out what unused import is causing? - For my own knowledge!
pandas/_libs/hashing.c:25344:20: warning: ‘__pyx_memview_get_object’

Also I randomly get this warning: (which doesn't seem to be as expected)

pandas/_libs/src/ujson/python/objToJSON.c: In function ‘NpyArr_encodeLabels’:
pandas/_libs/src/ujson/python/objToJSON.c:1616:18: warning: ‘len’ may be used uninitialized in this function [-Wmaybe-uninitialized]

@jbrockmendel
Copy link
Member Author

What's the best way of figuring out what unused import is causing? - For my own knowledge!

No idea

@WillAyd
Copy link
Member

WillAyd commented Jan 5, 2020

The one is caused by Cython so can't speak to that but for the JSON one if you look at the line:

ret[i] = PyObject_Malloc(len + 1);

The warning is saying that there are some code paths where len is declared but never assigned, which would give it an undefined value and either give weird results or segfault if that line gets hit without len ever having been assigned.

Not clear what path that is though - you are only getting the warning intermittently?

@WillAyd WillAyd added this to the 1.0 milestone Jan 6, 2020
@WillAyd WillAyd merged commit bf8a23d into pandas-dev:master Jan 6, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 6, 2020

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the cln-warns branch January 6, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants