-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BLD: address build warnings #30639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: address build warnings #30639
Conversation
Nice! Does this address all of them? |
Not sure if you've seen it, but besides the failure in the docs, this error is happening lots of times in the tests:
|
No. Locally (only checked OSX) it addresses the buffer unpacking in aggregations.pyx and the assignment warnings for algos.c. The __pyx_memview_get_object ones I think are coming from an unused import; they dont correspond directly to any of the .pyx code |
Nice! What's the best way of figuring out what unused import is causing? - For my own knowledge! Also I randomly get this warning: (which doesn't seem to be as expected)
|
No idea |
The one is caused by Cython so can't speak to that but for the JSON one if you look at the line: pandas/pandas/_libs/src/ujson/python/objToJSON.c Line 1616 in 4206fd4
The warning is saying that there are some code paths where Not clear what path that is though - you are only getting the warning intermittently? |
Thanks @jbrockmendel |
xref #30609