BLD: address build warnings

[jbrockmendel]

xref #30609

[WillAyd]

Nice! Does this address all of them?

[datapythonista]

Not sure if you've seen it, but besides the failure in the docs, this error is happening lots of times in the tests:

Exception ignored in: 'pandas._libs.window.aggregations.is_monotonic_start_end_bounds'

TypeError: Argument 'arr' has incorrect type (expected numpy.ndarray, got pandas._libs.window.aggregations._memoryviewslice)

[jbrockmendel]

Does this address all of them?

No. Locally (only checked OSX) it addresses the buffer unpacking in aggregations.pyx and the assignment warnings for algos.c. The __pyx_memview_get_object ones I think are coming from an unused import; they dont correspond directly to any of the .pyx code

[alimcmaster1]

Does this address all of them?

No. Locally (only checked OSX) it addresses the buffer unpacking in aggregations.pyx and the assignment warnings for algos.c. The __pyx_memview_get_object ones I think are coming from an unused import; they dont correspond directly to any of the .pyx code

Nice! What's the best way of figuring out what unused import is causing? - For my own knowledge!
pandas/_libs/hashing.c:25344:20: warning: ‘__pyx_memview_get_object’

Also I randomly get this warning: (which doesn't seem to be as expected)

pandas/_libs/src/ujson/python/objToJSON.c: In function ‘NpyArr_encodeLabels’:
pandas/_libs/src/ujson/python/objToJSON.c:1616:18: warning: ‘len’ may be used uninitialized in this function [-Wmaybe-uninitialized]

[jbrockmendel]

What's the best way of figuring out what unused import is causing? - For my own knowledge!

No idea

[WillAyd]

The one is caused by Cython so can't speak to that but for the JSON one if you look at the line:

pandas/pandas/_libs/src/ujson/python/objToJSON.c

Line 1616 in 4206fd4

ret[i] = PyObject_Malloc(len + 1);

The warning is saying that there are some code paths where len is declared but never assigned, which would give it an undefined value and either give weird results or segfault if that line gets hit without len ever having been assigned.

Not clear what path that is though - you are only getting the warning intermittently?

[WillAyd]

Thanks @jbrockmendel