Skip to content

DOC: Add strings for dtypes in basic.rst #30628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 3, 2020

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Jan 2, 2020

Decided to add all valid strings for all the types in the table about dtypes. I didn't want to decide which ones to leave out, and if we want to leave some of them out, we should decide whether they should be removed from the code as well (e.g., 'Sparse[int, 0]')

Had to reformat the table so it would look nice, by splitting the list of strings into multiple lines (e.g., a merged cell)

@jreback jreback added Docs Dtype Conversions Unexpected or buggy dtype conversions labels Jan 3, 2020
@jreback jreback added this to the 1.0 milestone Jan 3, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@datapythonista datapythonista changed the title DOC: Add strings for dypes in basic.rst DOC: Add strings for dtypes in basic.rst Jan 3, 2020
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one small thing.

@datapythonista datapythonista merged commit 9fb3040 into pandas-dev:master Jan 3, 2020
@datapythonista
Copy link
Member

Thanks @Dr-Irv, nice addition

@Dr-Irv Dr-Irv deleted the dtypedoc branch January 3, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Add info on dtype strings
4 participants