Skip to content

Improve ASV Environment Creation Performance #30611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Jan 2, 2020

...by leveraging a lot of the recent work to enable parallel CI

Overriding default values documented here:

https://asv.readthedocs.io/en/stable/asv.conf.json.html#build-command-install-command-uninstall-command

I've picked 4 as the value assuming most people running benchmarks will have 2-4 cores. YMMV

@jreback jreback added the Performance Memory or execution speed performance label Jan 2, 2020
@jbrockmendel
Copy link
Member

LGTM. any ballpark on the perf imrpovement?

@WillAyd
Copy link
Member Author

WillAyd commented Jan 2, 2020 via email

@TomAugspurger TomAugspurger merged commit 8806ed7 into pandas-dev:master Jan 2, 2020
@TomAugspurger
Copy link
Contributor

Thanks! Will report how it does on the benchmark machine.

@WillAyd WillAyd deleted the asv-build-perf branch January 16, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants