Skip to content

REF: share _wrap_joined_index #30599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2020
Merged

REF: share _wrap_joined_index #30599

merged 1 commit into from
Jan 1, 2020

Conversation

jbrockmendel
Copy link
Member

this is the last of the trivial ones AFAICT. To get the others we're going to have to smooth out small differences in behavior, which should happen in non-refactoring PRs.

@jreback jreback added the Refactor Internal refactoring of code label Jan 1, 2020
@jreback jreback added this to the 1.0 milestone Jan 1, 2020
jreback
jreback approved these changes Jan 1, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit 2b0d1a1 into pandas-dev:master Jan 1, 2020
@jreback
Copy link
Contributor

jreback commented Jan 1, 2020

thanks

@jbrockmendel jbrockmendel deleted the ref-share-3 branch January 1, 2020 16:32
hweecat pushed a commit to hweecat/pandas that referenced this pull request Jan 1, 2020
@jbrockmendel @hweecat
share _wrap_joined_index (pandas-dev#30599)
afdb801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback