Skip to content

PERF: Fixed performance regression in Series init #30571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2019
Merged

PERF: Fixed performance regression in Series init #30571

merged 2 commits into from
Dec 31, 2019

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Dec 30, 2019 •
edited
Loading

Closes #30564

PR

[ 50.00%] ··· series_methods.SeriesConstructor.time_constructor                                                                                                                   ok
[ 50.00%] ··· ====== ==========
               data
              ------ ----------
               None   670±0μs
               dict   84.4±0ms
              ====== ==========

master

[ 50.00%] ··· series_methods.SeriesConstructor.time_constructor                                                                                                                   ok
[ 50.00%] ··· ====== =========
               data
              ------ ---------
               None   756±0μs
               dict   725±0ms
              ====== =========

No whatsnew, since the regression was only on master.

@TomAugspurger TomAugspurger added this to the 1.0 milestone Dec 30, 2019
@TomAugspurger TomAugspurger added the Performance Memory or execution speed performance label Dec 30, 2019
@TomAugspurger
Copy link
Contributor Author

Also pushed a change to avoid calling construct_from_string from ExtensionDtype.is_dtype for non-string inputs in the first place.

@jbrockmendel
Copy link
Member

Lgtm

@jbrockmendel jbrockmendel merged commit ee42275 into pandas-dev:master Dec 31, 2019
@jbrockmendel
Copy link
Member

Thanks @TomAugspurger

hweecat pushed a commit to hweecat/pandas that referenced this pull request Jan 1, 2020
@TomAugspurger @hweecat
PERF: Fixed performance regression in Series init (pandas-dev#30571)
7e13b52 
* PERF: Fixed performance regression in Series init

Closes pandas-dev#30564

* avoid calling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Performance Memory or execution speed performance
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

PERF: regression in Series constructor
2 participants
@TomAugspurger @jbrockmendel