TST/BUG: fix incorrectly-passing Exception in test_html #30553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Dec 30, 2019
| self._setup_build_doc(), features="html5lib", from_encoding=self.encoding | ||
| ) | ||
| bdoc = self._setup_build_doc() | ||
| if isinstance(bdoc, bytes) and self.encoding is not None: |
There was a problem hiding this comment.
this is very strange
so this sometimes returns bytes? and str otherwise?
There was a problem hiding this comment.
i dont know this code particularly well, found this while tracking down except Exception. AFAICT sometimes bs4 wants bytes
simonjayhawkins
added
Bug
IO HTML
|
gentle ping. not a blocker, but it is a bugfix so it'd be nice to get it in for the RC |
jreback
approved these changes
Jan 18, 2020
|
lgtm. can you rebase just in case. ping on green. |
|
rebased+green |
|
thanks |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 18, 2020
…ion in test_html
jreback
pushed a commit
that referenced
this pull request
Jan 18, 2020
…t_html (#31124) Co-authored-by: jbrockmendel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
raiseis indented one indent further than it should be. Fixing this surfaces a failing test that is fixed by decoding bytes before passing it to bs4.