Skip to content

TST: XFAIL Travis read_html tests #30544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 31, 2019
Merged

TST: XFAIL Travis read_html tests #30544

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2d4dd51
XFAIL Tests
alimcmaster1 Dec 29, 2019
2768e2c
XFAIL Tests
alimcmaster1 Dec 29, 2019
8acd4f0
Update as per brock suggestion
alimcmaster1 Dec 29, 2019
9cab2ad
unpin beautiful soup version
alimcmaster1 Dec 30, 2019
574723f
Dont xfail for bs4 < 4.8.0
alimcmaster1 Dec 31, 2019
804560f
Remove slow tests from allowed failures
alimcmaster1 Dec 31, 2019
7faa5ef
black pandas
alimcmaster1 Dec 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pandas/tests/io/test_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,10 @@ def test_thousands_macau_stats(self, datapath):

@pytest.mark.slow
def test_thousands_macau_index_col(self, datapath):
# https://github.com/pandas-dev/pandas/issues/29622
if self.read_html.keywords.get("flavor") == "bs4":
pytest.xfail("fails for bs4 version >= 4.8.0")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you change this from the decorator in response to my comment? if so, thats not what i meant. the decorator is preferred, but without the strict=False

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just want to xfail one particular parameterization - bs4 and the parameterization is at class scope - agree decorator is usually preferred.

Updated now - think its easiest to do this in the function itself for this case - unless you know a more elegant way?

Copy link
Member Author

@alimcmaster1 alimcmaster1 Dec 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seen I can potentially go for the same approach as you did here https://github.com/pandas-dev/pandas/pull/30521/files? Will update unless you think otherwise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the test doesnt use the class fixture(s), could it just be moved out of the class?

If not then the approach in 30521 would be my preference, yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some class fixtures are used so easier to keep where is. Updated - thanks!

all_non_nan_table_index = -2
macau_data = datapath("io", "data", "html", "macau.html")
dfs = self.read_html(macau_data, index_col=0, header=0)
Expand Down