BUG: pass 2D ndarray and EA-dtype to DataFrame, closes #12513 #30507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Dec 27, 2019
|
Can you add a whatsnew for this? |
jreback
requested changes
Dec 27, 2019
jreback
added
Bug
Constructors
jreback
reviewed
Jan 1, 2020
| @@ -2551,3 +2551,11 @@ def test_from_tzaware_mixed_object_array(self): | |||
| "datetime64[ns, CET]", | |||
| ] | |||
| assert (res.dtypes == expected_dtypes).all() | |||
|
|
|||
| def test_from_2d_ndarray_with_dtype(self): | |||
There was a problem hiding this comment.
can you make this test more generic and add to the EA tests instead (followup ok)
jreback
requested changes
Jan 1, 2020
jreback
approved these changes
Jan 1, 2020
|
thanks, followup (pls create an issue or add to list) |
hweecat
pushed a commit
to hweecat/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dtype='datetime64[ns, UTC]'#12513black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff