CLN/DOC: standardize wording on previous-removals #30488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Dec 26, 2019
| - Removed the previously deprecated "labels" keyword from :meth:`MultiIndex.set_codes`, :meth:`MultiIndex.copy`, :meth:`MultiIndex.drop`, use "codes" instead (:issue:`23752`) | ||
| - Removed support for legacy HDF5 formats (:issue:`29787`) | ||
| - Passing a dtype alias (e.g. 'datetime64[ns, UTC]') to :class:`DatetimeTZDtype` is no longer allowed, use :meth:`DatetimeTZDtype.construct_from_string` instead (:issue:`23990`) | ||
| - :func:`read_excel` removed support for "skip_footer" argument, use "skipfooter" instead (:issue:`18836`) | ||
| - :func:`read_excel` no longer allows an integer value for the parameter ``usecols``, instead pass a list of integers from 0 to ``usecols`` inclusive (:issue:`23635`) | ||
| - :meth:`DataFrame.to_records` no longer supports the argument "convert_datetime64" (:issue:`18902`) | ||
| - Removed the previously deprecated ``IntervalIndex.from_intervals`` in favor of the :class:`IntervalIndex` constructor (:issue:`19263`) |
There was a problem hiding this comment.
note this also changes double-backticks to :meth:, unless there was a reason for this?
|
The next step in this process would be to standardize wording for "removed keyword X from Y" |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 1.0.0 whatsnew we currently have 3 variants of "Removed :foo:X"
I think we should standardize on one of these (lest readers think the difference is meaningful). I don't particularly care which, but for this PR went with the last one as it is the least verbose