Skip to content

TST: Xfailing broken GBQ test #30472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 25, 2019
Merged

TST: Xfailing broken GBQ test #30472

merged 1 commit into from
Dec 25, 2019

Conversation

datapythonista
Copy link
Member

xref #30470

Test recently introduced in #30447 seems to be failing in master. Xfailing it for now.

CC: @jreback

@datapythonista datapythonista added Testing pandas testing functions or related to the test suite IO Google labels Dec 25, 2019
@jreback jreback added this to the 1.0 milestone Dec 25, 2019
@jreback
Copy link
Contributor

jreback commented Dec 25, 2019

thanks @datapythonista

@jreback jreback merged commit 0dc7b5c into pandas-dev:master Dec 25, 2019
@jreback
Copy link
Contributor

jreback commented Dec 25, 2019

thanks @datapythonista

@jreback
Copy link
Contributor

jreback commented Dec 26, 2019

hmm https://travis-ci.org/pandas-dev/pandas/jobs/629507853 this must be called multiple times.

@alimcmaster1
Copy link
Member

@jreback I think the problem is the test is now passing.

_ TestToGBQIntegrationWithServiceAccountKeyPath.test_gbq_if_exists[append-300] _
[gw1] linux -- Python 3.6.6 /home/travis/miniconda3/envs/pandas-dev/bin/python
[XPASS(strict)] Test breaking master

https://travis-ci.org/pandas-dev/pandas/jobs/629502988

and we have xfail_strict = True set in our setup.cfg.

Ill turn strict off for this test

AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
@datapythonista @AlexKirko
TST: Xfailing broken GBQ test (pandas-dev#30472)
90cb804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@datapythonista @jreback @alimcmaster1