Skip to content

CLN: OrderedDict -> Dict #30471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 26, 2019
Merged

CLN: OrderedDict -> Dict #30471

merged 2 commits into from
Dec 26, 2019

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 added Clean Code Style Code style, linting, code_checks labels Dec 25, 2019
@jreback
Copy link
Contributor

jreback commented Dec 25, 2019

lgtm ping when ready. don't have to do them all in a single PR

@alimcmaster1 alimcmaster1 marked this pull request as ready for review December 25, 2019 23:58
@alimcmaster1
Copy link
Member Author

lgtm ping when ready. don't have to do them all in a single PR

Thanks ready - will address the renaming cases + code check in a follow up.

@jreback jreback added this to the 1.0 milestone Dec 26, 2019
@jreback jreback merged commit 379e9ba into pandas-dev:master Dec 26, 2019
@jreback
Copy link
Contributor

jreback commented Dec 26, 2019

thanks @alimcmaster1

@alimcmaster1 alimcmaster1 deleted the mcmali-dict branch December 26, 2019 03:06
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
@alimcmaster1 @AlexKirko
CLN: OrderedDict -> Dict (pandas-dev#30471)
4929e81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alimcmaster1 @jreback