BUG/Compat: dt64/td64 cummin, cummax on np 1.18 #30460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes at least one of the cases in #15553, will see if the others are already fixed+tested |
jreback
added
Compat
jreback
reviewed
Dec 25, 2019
| @@ -11131,11 +11131,35 @@ def cum_func(self, axis=None, skipna=True, *args, **kwargs): | |||
| axis = self._get_axis_number(axis) | |||
|
|
|||
| y = com.values_from_object(self).copy() | |||
| d = self._construct_axes_dict() | |||
There was a problem hiding this comment.
ok, in the future let's refactor if possible.
jreback
approved these changes
Dec 25, 2019
jreback
reviewed
Dec 25, 2019
| d["copy"] = False | ||
|
|
||
| if issubclass(y.dtype.type, (np.datetime64, np.timedelta64)): | ||
| # numpy 1.18 started sorting NaTs at the end instead of beginning, |
There was a problem hiding this comment.
also add issue numbers here for future reference (follown)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis also fixes+tests Series cummin/cummax with dt64tz, will have to look to see if there are any GH issues for that.
Following this and #29872 I think we should refactor a bunch of this out into core.nanops.