Replaced .format{}/% with f-strings in core/tools/datetime.py #30440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifeid to python3 format strings ref: pandas-dev#29547
|
suggest labels clean & style for this pull request, & part of the 1.0 milestone. |
`black pandas` altered the code formatting
This reverts commit 63fd66d.
`black pandas` auto-formatting update. Changes line breaks due to f-strings being more concise. Some of the changes were stupid and I have taken out the extra `" "` on single line `raise` statements.
remove trailing whitespace, join() not performed inline in f-strings. update passes `black pandas` test
|
thanks @JMBurley |
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified to python3 format strings
ref: #29547
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffwhatsnew entry(will not add now. I think the full set of changes in Replace old string formatting syntax with f-strings #29547 should get a single update entry rather than a piecemeal one)