ISORT: Add _typing to pre_core isort block #30423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alimcmaster1
commented
Dec 23, 2019
alimcmaster1
commented
- closes STY: add pandas._typing to the known_pre_core block for isort #27534
asv_bench/benchmarks/io/excel.py
Outdated
| from odf.opendocument import OpenDocumentSpreadsheet | ||
| from odf.table import Table, TableCell, TableRow | ||
| from odf.text import P | ||
|
|
|
can you rebase and ping on green. as just merged some more things. |
|
@jreback done and green - thanks! |
|
thanks @alimcmaster1 is this automatically pickuped up in the pre-commit hooks? (I think yes, just confirming) |
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.