Replaced xrange with range #30417
Merged
Replaced xrange with range #30417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaharNaveh
commented
Dec 22, 2019
| @@ -585,10 +585,6 @@ def test_strange_column_corruption_issue(self): | |||
| df = DataFrame(index=[0, 1]) | |||
| df[0] = np.nan | |||
| wasCol = {} | |||
| # uncommenting these makes the results match | |||
| # for col in xrange(100, 200): | |||
There was a problem hiding this comment.
This code block is sitting commented for over 4 years. thtat's the only reason I deleted it all. and not just changed the xrange to range
topper-123
approved these changes
Dec 23, 2019
|
LGTM |
WillAyd
approved these changes
Dec 23, 2019
|
Nice - thanks @MomIsBestFriend |
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff