TYP: Typing annotations pandas/util/ #30411
Conversation
ShaharNaveh
changed the title
| @@ -37,7 +37,7 @@ def test_foo(): | |||
| from pandas.core.computation.expressions import _NUMEXPR_INSTALLED, _USE_NUMEXPR | |||
|
|
|||
|
|
|||
| def safe_import(mod_name, min_version=None): | |||
| def safe_import(mod_name: str, min_version: Optional[str] = None): | |||
There was a problem hiding this comment.
| def safe_import(mod_name: str, min_version: Optional[str] = None): | |
| def safe_import(mod_name: str, min_version: Optional[str] = None) -> Union[types.ModuleType, bool]: |
Actually not 100% sure on this one but would be nice if return type could be annotated as well
There was a problem hiding this comment.
Code style question, what is preferred here?
from types import ModuleTypeor
import typesThere was a problem hiding this comment.
NVM, mypy complains about it anyway.
pandas/util/_validators.py
Outdated
|
|
||
| compat_args: OrderedDict | ||
| A ordered dictionary of keys and their associated default values. | ||
| compat_args : OrderedDict |
There was a problem hiding this comment.
Is this still an OrderedDict? IIRC we removed all occurrences of those from code base recently
There was a problem hiding this comment.
Remove it from the doc?
There was a problem hiding this comment.
Hmm was going to say just label as dict but it looks like there is a detailed note about ordered requirements. Still should just be a dict but have to clean up the associated note; can do in a follow up if you'd like
There was a problem hiding this comment.
Looking at the detailed note, it's just to be compatible some buggy versions of numpy, and by looking at the git-blame of it, it way 4 years ago.
It's probably fixed by now, but I really cant know for sure, because there's no mention of a
specific/range of problematic numpy's versions.
Do you feel comfortable with removing the detailed note about the OrderedDict?
ShaharNaveh
force-pushed
the
TYP-util
branch
2 times, most recently
from
592ed71 to
ef5b45d
Compare
ShaharNaveh
force-pushed
the
TYP-util
branch
from
ef5b45d to
70b5af4
Compare
| @@ -195,7 +195,9 @@ def skip_if_no(package: str, min_version: Optional[str] = None) -> Callable: | |||
| ) | |||
|
|
|||
|
|
|||
| def skip_if_np_lt(ver_str, reason=None, *args, **kwds): | |||
| def skip_if_np_lt( | |||
There was a problem hiding this comment.
these could actually be a pytest.mark.skipif type (not sure what that actually is though)
There was a problem hiding this comment.
but can address that later if so desired
|
thanks @MomIsBestFriend |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff