TYP: Type annotations in pandas/io/formats/printing.py #30404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couple of comments, generally looks good. I'm not sure, but it may be the case that since py2 was dropped some usages of pprint_thing throughout the code base are now unnecessary |
ShaharNaveh
force-pushed
the
TYP-io-formats-html/printing
branch
2 times, most recently
from
55a93ee to
0a9294d
Compare
WillAyd
requested changes
Dec 23, 2019
ShaharNaveh
force-pushed
the
TYP-io-formats-html/printing
branch
from
0a9294d to
0bf71d0
Compare
|
thanks @MomIsBestFriend |
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff