Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENH: Add ignore_index for df.sort_values and series.sort_values #30402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add ignore_index for df.sort_values and series.sort_values #30402
Changes from all commits
7e461a1
1314059
8bcb313
1f9a4ce
5f924c3
d0a134f
6d52765
a31797d
b80f380
b997d3f
12d1260
4ff2493
e9d63f4
70ffec7
b4245d7
f9e7ec2
d95a89f
f241e67
7f9846a
bbb4754
3c37eb9
4ce9f43
0f89aa2
d02b651
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orthogonal to this but I wonder why this is specified as
np.int32
; might be a bug for input with more than 2 ** 32 - 1 rowsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numpy uses int32 for argsort so best can do (to be honest 2B is enough)